Skip to content

Support top-level-await in TypeScript#3024

Merged
ry merged 1 commit intodenoland:masterfrom
ry:top_level_await_ts
Sep 30, 2019
Merged

Support top-level-await in TypeScript#3024
ry merged 1 commit intodenoland:masterfrom
ry:top_level_await_ts

Conversation

@ry
Copy link
Member

@ry ry commented Sep 26, 2019 •
edited
Loading

Fixes #471

After this we should clean up the documentation...

@ry ry requested a review from piscisaureus September 26, 2019 02:25
@ry ry force-pushed the top_level_await_ts branch from 6221531 to 5b20b83 Compare September 26, 2019 02:25
@kitsonk
Copy link
Contributor

kitsonk commented Sep 28, 2019

TLA for TypeScript is scheduled for 3.7, planned for Nov 7th.

Refs: microsoft/TypeScript#33352 and microsoft/TypeScript#25988

piscisaureus
piscisaureus approved these changes Sep 30, 2019
View reviewed changes
Copy link
Member

@piscisaureus piscisaureus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I am expecting many subtle bugs in our top level await support.
E.g. certain type checks that typescript will get wrong, module initialization in the wrong order / racy, etc.

@ry
Copy link
Member Author

ry commented Sep 30, 2019

I am expecting many subtle bugs in our top level await support. E.g. certain type checks that typescript will get wrong, module initialization in the wrong order / racy, etc.

I wouldn't be surprised either - but some preliminary checks I did with TLA + type errors did report the correct error. But this is just a bandaid until TypeScript properly parses TLA.

@ry ry merged commit ae26a9c into denoland:master Sep 30, 2019
@ry ry deleted the top_level_await_ts branch September 30, 2019 16:38
@hayd
Copy link
Contributor

hayd commented Sep 30, 2019

Is top level for-await a distinct typescript/V8 issue?

@ry
Copy link
Member Author

ry commented Sep 30, 2019

@hayd yes - it’s not yet supported in v8

@CyrusNajmabadi CyrusNajmabadi mentioned this pull request Oct 3, 2019
Closed
@avindra avindra mentioned this pull request Oct 2, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@piscisaureus piscisaureus piscisaureus approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Support top-level await

4 participants

@ry @kitsonk @hayd @piscisaureus